Skip to content

MQE-2141: MFTF BIC Documentation #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 1, 2020
Merged

MQE-2141: MFTF BIC Documentation #716

merged 5 commits into from
Jun 1, 2020

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented May 26, 2020

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@soumyau soumyau requested a review from dobooth May 26, 2020 22:19
@coveralls
Copy link

Coverage Status

Coverage remained the same at 55.944% when pulling a411c0c on MQE-2141 into 545a266 on develop.

@coveralls
Copy link

coveralls commented May 26, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 55.91% when pulling 482d2b0 on MQE-2141 into 64e7788 on develop.

dobooth
dobooth previously approved these changes May 27, 2020
View reviewed changes
jilu1
jilu1 suggested changes May 29, 2020
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One minor comment for rewording.

docs/backward-incompatible-changes.md Outdated

This page highlights backward incompatible changes between releases that have a major impact and require detailed explanation and special instructions to ensure third-party tests continue working with Magento core tests.

## Version requirement changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be more specific call out as "Minimum supported PHP version changes"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to above, thanks!

jilu1
jilu1 approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@soumyau soumyau merged commit 48b4b2e into develop Jun 1, 2020
@tomreece tomreece deleted the MQE-2141 branch July 27, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 approved these changes

@dobooth dobooth dobooth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soumyau @coveralls @jilu1 @dobooth