Skip to content

MQE-2045: Upgrade script to remove unused arguments #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 8, 2020
Merged

MQE-2045: Upgrade script to remove unused arguments #696

merged 5 commits into from
May 8, 2020

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented May 6, 2020 •
edited
Loading

Description

  • Refactored ActionGroupArgumentsCheck.php to use DomDocument traversals instead of reg-ex
  • Reused static-check methods for removal of unused arguments

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented May 6, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 53.257% when pulling 40a2252 on MQE-2045 into df94717 on develop.

soumyau added 2 commits May 6, 2020 12:48
@soumyau
MQE-2045: Upgrade script to remove unused arguments
295bae7 
Fixed static checks, extracted some code into methods
@soumyau
MQE-2045: Upgrade script to remove unused arguments
a3d4650 
Fixed static checks
@tomreece
Copy link
Contributor

tomreece commented May 7, 2020

Looks good to me.

@soumyau soumyau merged commit 1de7456 into develop May 8, 2020
@tomreece tomreece deleted the MQE-2045 branch July 27, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomreece tomreece tomreece approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soumyau @coveralls @tomreece