Skip to content

MQE-2082: MFTF compatibility with 2fa #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 12, 2020
Merged

MQE-2082: MFTF compatibility with 2fa #692

merged 7 commits into from
May 12, 2020

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Apr 29, 2020

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@jilu1 jilu1 changed the title Mqe 2082 MQE-2082: MFTF compatibility with 2fa Apr 29, 2020
@coveralls
Copy link

coveralls commented Apr 30, 2020 •
edited
Loading

Coverage Status

Coverage increased (+2.6%) to 55.915% when pulling 686afb0 on MQE-2082 into cd13059 on develop.

@KevinBKozan
Copy link
Contributor

Reminder to refactor from .env usage to be .creds usage instead.

KevinBKozan
KevinBKozan reviewed May 4, 2020
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small questions on some changes. The core of the 2FA stuff seems solid so no worries there.

KevinBKozan
KevinBKozan previously approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. We can consider this more or less finalized until pipeline changes confirm it works.

@jilu1 jilu1 changed the base branch from 3.0.0-RC3 to develop May 12, 2020 15:36
@jilu1 jilu1 dismissed KevinBKozan’s stale review May 12, 2020 15:36

The base branch was changed.

@soumyau soumyau self-requested a review May 12, 2020 16:33
soumyau
soumyau reviewed May 12, 2020
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jilu1 can <getOTP> be added to a verification test for generation?

@jilu1
Copy link
Contributor Author

jilu1 commented May 12, 2020

#692 (review)
Added in verification test

soumyau
soumyau approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jilu1 jilu1 merged commit ce21f48 into develop May 12, 2020
@jilu1 jilu1 deleted the MQE-2082 branch May 12, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumyau soumyau soumyau approved these changes

@KevinBKozan KevinBKozan KevinBKozan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jilu1 @coveralls @KevinBKozan @soumyau