MQE-2034: Document Custom Helper functionality #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBKozan
reviewed
Apr 29, 2020
docs/custom-helpers.md
Outdated
|
|
||
| A Custom Helper is written in a PHP file and then referenced in test XML like other actions. | ||
|
|
||
| Due to complexity, you should only use these as a last resort after trying to implement your test using built-in actions. |
There was a problem hiding this comment.
This part is pretty important, I think we should include a when to use/when to NOT use at the top to highlight it.
There was a problem hiding this comment.
I added a warning block to the top of the page.
KevinBKozan
previously approved these changes
Apr 29, 2020
There was a problem hiding this comment.
Looks good now. IMO it's ready for @dobooth, your call on waiting on alex's review
|
I'll wait on @okolesnyk since he's the one who implemented custom helpers. |
okolesnyk
previously approved these changes
Apr 30, 2020
dobooth
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: