Skip to content

MQE-2077: [PHPUnit 9] Remove assertArraySubset, assertInternalType, a… #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2020
Merged

MQE-2077: [PHPUnit 9] Remove assertArraySubset, assertInternalType, a… #677

merged 2 commits into from
Apr 21, 2020

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Apr 17, 2020

…ssertNotInternalType

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Apr 17, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 52.839% when pulling d2e6c55 on MQE-2077 into e9b96a3 on MFTF3.0.0-RC2.

KevinBKozan
KevinBKozan previously approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, just need to see a UR build to make sure they aren't failing!

soumyau
soumyau previously approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jilu1 jilu1 dismissed stale reviews from soumyau and KevinBKozan via d2e6c55 April 21, 2020 19:30
@jilu1 jilu1 merged commit c8855c0 into MFTF3.0.0-RC2 Apr 21, 2020
@tomreece tomreece deleted the MQE-2077 branch May 1, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumyau soumyau soumyau approved these changes

@KevinBKozan KevinBKozan KevinBKozan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jilu1 @coveralls @soumyau @KevinBKozan