Skip to content

MQE-2026: ModuleResolver handle test module that depends on more than… #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2020
Merged

MQE-2026: ModuleResolver handle test module that depends on more than… #635

merged 2 commits into from
Mar 12, 2020

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Mar 12, 2020

… one Magento modules

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Mar 12, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 51.039% when pulling cd7fc0e on MQE-2026 into a4d08e0 on develop.

KevinBKozan
KevinBKozan approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, the compound modules can be resolved just fine

@jilu1 jilu1 merged commit ca1cbdc into develop Mar 12, 2020
@tomreece tomreece deleted the MQE-2026 branch May 1, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jilu1 @coveralls @KevinBKozan