Skip to content

MQE-2016: Add warning for test materials that violate naming convention #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 11, 2020
Merged

MQE-2016: Add warning for test materials that violate naming convention #616

merged 5 commits into from
Mar 11, 2020

Conversation

tomreece
Copy link
Contributor

@tomreece tomreece commented Mar 5, 2020 •
edited
Loading

Build:
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/30465/
Note: This build has failures around video tests, but this is also a problem in mainline right now too.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 52.463% when pulling 081692d on MQE-2016 into 32e7600 on develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 52.463% when pulling 081692d on MQE-2016 into 32e7600 on develop.

@coveralls
Copy link

coveralls commented Mar 5, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 51.074% when pulling 6aaa2f0 on MQE-2016 into bedde57 on develop.

@soumyau soumyau self-requested a review March 9, 2020 14:18
soumyau
soumyau suggested changes Mar 9, 2020
View reviewed changes
soumyau
soumyau reviewed Mar 10, 2020
View reviewed changes
soumyau
soumyau approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@tomreece tomreece merged commit c37ba96 into develop Mar 11, 2020
@tomreece tomreece deleted the MQE-2016 branch April 30, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumyau soumyau soumyau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomreece @coveralls @soumyau