Skip to content

MQE-683: Assert action deprecation + upgrade #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 12, 2020
Merged

MQE-683: Assert action deprecation + upgrade #614

merged 14 commits into from
Mar 12, 2020

Conversation

KevinBKozan
Copy link
Contributor

@KevinBKozan KevinBKozan commented Mar 4, 2020 •
edited
Loading

TODO:

  • Create CE/EE/B2B/Ext branches and merge into 3.0.0 branch

@KevinBKozan
MQE-683: [Deprecation] Only use more nested assertion syntax
61027d9 
- Deprecated one-line syntax
- added upgrade script
@KevinBKozan
MQE-683: [Deprecation] Only use more nested assertion syntax
35818bb 
- static check fixes
@KevinBKozan
MQE-683: [Deprecation] Only use more nested assertion syntax
173f9b3 
- Heavy updates to script
- Update to AssertElementContainsAttribute action
@KevinBKozan
MQE-683: [Deprecation] Only use more nested assertion syntax
fecb9f6 
- Bugfix for empty value
@KevinBKozan
MQE-683: [Deprecation] Only use more nested assertion syntax
e5666c1 
- Update to conversion script
@KevinBKozan
MQE-683: [Deprecation] Only use more nested assertion syntax
ac8d76e 
- More fixes
@KevinBKozan
MQE-683: [Deprecation] Only use more nested assertion syntax
3a901e3 
- Even more fixes
@KevinBKozan
MQE-683: [Deprecation] Only use more nested assertion syntax
af17d02 
- Cleanup
@KevinBKozan
Merge branch 'develop' into MQE-683
79cae33
@KevinBKozan
MQE-683: [Deprecation] Only use more nested assertion syntax
f578c08 
- Safe update to upgrade script (better assert detection
- Change back to TestGenerator to pass test again
- Updated schema in AssertTest
- Added back type to AssertContainsAttribute type (needed)
@coveralls
Copy link

coveralls commented Mar 4, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 51.031% when pulling 0a21795 on MQE-683 into c37ba96 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 52.422% when pulling f578c08 on MQE-683 into 81cfd36 on develop.

@soumyau soumyau self-requested a review March 10, 2020 15:11
soumyau
soumyau suggested changes Mar 11, 2020
View reviewed changes
soumyau
soumyau reviewed Mar 11, 2020
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, some unused code removal changes suggested 👍

soumyau
soumyau previously approved these changes Mar 11, 2020
View reviewed changes
@KevinBKozan KevinBKozan requested a review from soumyau March 12, 2020 13:57
soumyau
soumyau previously approved these changes Mar 12, 2020
View reviewed changes
@KevinBKozan KevinBKozan requested a review from soumyau March 12, 2020 14:06
@KevinBKozan KevinBKozan merged commit 5990abb into develop Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumyau soumyau soumyau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBKozan @coveralls @soumyau