Skip to content

MQE-1963: Update XSD Schema to verify that file has only single entity #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 10, 2020
Merged

MQE-1963: Update XSD Schema to verify that file has only single entity #602

merged 15 commits into from
Mar 10, 2020

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Feb 19, 2020

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Feb 19, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-1.6%) to 50.548% when pulling 029d896 on MQE-1963 into 264aaea on develop.

@jilu1 jilu1 force-pushed the MQE-1963 branch 4 times, most recently from e12619e to f353e42 Compare February 20, 2020 18:49
okolesnyk
okolesnyk requested changes Feb 20, 2020
View reviewed changes
Copy link
Member

@okolesnyk okolesnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not create new FileResolver since we already have one which should fulfill our needs

@okolesnyk okolesnyk self-requested a review March 2, 2020 18:15
tomreece
tomreece reviewed Mar 2, 2020
View reviewed changes
okolesnyk
okolesnyk requested changes Mar 3, 2020
View reviewed changes
Copy link
Member

@okolesnyk okolesnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comments

@jilu1 jilu1 requested a review from dobooth March 3, 2020 20:38
@jilu1
Copy link
Contributor Author

jilu1 commented Mar 3, 2020 •
edited
Loading

Addressed review feedback. @okolesnyk @tomreece Please re-review.

@jilu1
Copy link
Contributor Author

jilu1 commented Mar 3, 2020

@dobooth Please review devdocs changes

@jilu1
Merge remote-tracking branch 'origin/develop' into MQE-1963
378cb3f 
# Conflicts:
#	etc/di.xml
#	src/Magento/FunctionalTestingFramework/Upgrade/UpgradeScriptList.php
@jilu1 jilu1 force-pushed the MQE-1963 branch 2 times, most recently from be7a672 to 5e62279 Compare March 4, 2020 16:14
dobooth
dobooth suggested changes Mar 4, 2020
View reviewed changes
@jilu1
Copy link
Contributor Author

jilu1 commented Mar 5, 2020

@dobooth Thanks for the feedbacks! Issues addressed.

@okolesnyk
Copy link
Member

https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/30501/

dobooth
dobooth previously approved these changes Mar 6, 2020
View reviewed changes
@jilu1
Copy link
Contributor Author

jilu1 commented Mar 10, 2020

@okolesnyk I applied your commit, fixed static test failure and updated the branch.

@okolesnyk okolesnyk requested review from tomreece and dobooth March 10, 2020 16:55
@jilu1 jilu1 merged commit 5ecf5be into develop Mar 10, 2020
@jilu1 jilu1 deleted the MQE-1963 branch May 1, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okolesnyk okolesnyk okolesnyk approved these changes

@tomreece tomreece Awaiting requested review from tomreece

@dobooth dobooth Awaiting requested review from dobooth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jilu1 @coveralls @okolesnyk @tomreece @dobooth