Skip to content

MQE-1961 Remove deprecated actions #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 20, 2020
Merged

MQE-1961 Remove deprecated actions #581

merged 5 commits into from
Feb 20, 2020

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Feb 7, 2020

executeInSelenium
performOn

  • fixed verification tests

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@soumyau
MQE-1961: Remove deprecated actions
4f6812d 
executeInSelenium
performOn
+ fixed verification tests
@soumyau soumyau changed the title MQE-1676: Remove deprecated actions MQE-1961 Remove deprecated actions Feb 7, 2020
@coveralls
Copy link

coveralls commented Feb 7, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 50.948% when pulling 7c3609a on MQE-1961 into b68484f on develop.

jilu1
jilu1 suggested changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment.

jilu1
jilu1 previously approved these changes Feb 11, 2020
View reviewed changes
@soumyau
MQE-1961: Remove deprecated actions
d505966 
resolved conflicts with develop
@soumyau
MQE-1961: Remove deprecated actions
8026f6f 
fixing verification tests
@soumyau
MQE-1961: Remove deprecated actions
7c3609a 
removed deprecation notices, and changes from 2.6.1
jilu1
jilu1 approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@soumyau soumyau merged commit 76693d9 into develop Feb 20, 2020
@soumyau soumyau deleted the MQE-1961 branch April 30, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soumyau @coveralls @jilu1