Skip to content

Removes reference files from MFTF repo #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

dobooth
Copy link
Contributor

@dobooth dobooth commented Feb 5, 2020

Description

This PR removes two files from the repo. They will be hosted in the devdocs repo instead to reduce complexity.
Check with Don before merging.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

Coverage Status

Coverage remained the same at 50.994% when pulling 309a1f2 on magento-devdocs:db_remove_refs into 3609f4f on magento:master.

Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dobooth
What's the reason to remove these references?

@dobooth
Copy link
Contributor Author

dobooth commented Feb 12, 2020

Couple reasons: 1) These are really codebase references, rather than MFTF references, so devdocs is a better place for it. 2) The topics are in the MFTF repo but the data file and build logic is on devdocs. This change will keep all the files in devdocs and make the process more stable. There was a Git issue with the MFTF repo a couple weeks ago that broke the devdocs build system. This will help prevent that in the future.

@dobooth dobooth requested a review from jilu1 February 12, 2020 16:16
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks for the information!

@KevinBKozan KevinBKozan merged commit b918c10 into magento:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants