Skip to content

Added missing node #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2020
Merged

Added missing node #571

merged 1 commit into from
Feb 26, 2020

Conversation

ajithkumar-maragathavel
Copy link
Contributor

Description

Added a missing operations node in the example.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Feb 2, 2020
@coveralls
Copy link

coveralls commented Feb 2, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-1.5%) to 50.994% when pulling a2b0cdd on ajithkumar-maragathavel:mftf-metadata into fc598db on magento:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 50.758% when pulling a2b0cdd on ajithkumar-maragathavel:mftf-metadata into fc598db on magento:develop.

dobooth
dobooth suggested changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@dobooth dobooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc contributions should be submitted to master.

@ajithkumar-maragathavel ajithkumar-maragathavel changed the base branch from develop to master February 18, 2020 19:38
@ajithkumar-maragathavel
Copy link
Contributor Author

@dobooth Changed the base branch to master.

@KevinBKozan KevinBKozan merged commit 0c19ad4 into magento:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

@dobooth dobooth dobooth approved these changes

@052b-dev 052b-dev Awaiting requested review from 052b-dev

@06romix 06romix Awaiting requested review from 06romix

@4lexvav 4lexvav Awaiting requested review from 4lexvav

@75harshverma 75harshverma Awaiting requested review from 75harshverma

Assignees
No one assigned
Labels
Partner: Ziffity partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ajithkumar-maragathavel @coveralls @KevinBKozan @dobooth @magento-engcom-team