Skip to content

Example added for grapValueFrom element #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2020
Merged

Example added for grapValueFrom element #561

merged 2 commits into from
Feb 26, 2020

Conversation

ajithkumar-maragathavel
Copy link
Contributor

Description

Example added from the existing test file for grapValueFrom element

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Jan 25, 2020
@coveralls
Copy link

coveralls commented Jan 25, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 51.063% when pulling 0f305eb on ajithkumar-maragathavel:mftf-data-example into 8b33258 on magento:master.

dobooth
dobooth suggested changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@dobooth dobooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following is an example of the Magento/Catalog/Test/Mftf/ActionGroup/AssertDiscountsPercentageOfProductsActionGroup.xml test:

@ajithkumar-maragathavel ajithkumar-maragathavel changed the base branch from develop to master February 18, 2020 19:49
@ajithkumar-maragathavel
Copy link
Contributor Author

@dobooth Made the changes you requested, and also changed the base branch to master.
Thanks for the review.

@KevinBKozan KevinBKozan merged commit 3426237 into magento:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

@dobooth dobooth dobooth approved these changes

@okolesnyk okolesnyk Awaiting requested review from okolesnyk

Assignees
No one assigned
Labels
Partner: Ziffity partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ajithkumar-maragathavel @coveralls @KevinBKozan @dobooth @magento-engcom-team