Skip to content

MQE-1959: Static-checks command can be configured #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2020
Merged

MQE-1959: Static-checks command can be configured #556

merged 2 commits into from
Jan 24, 2020

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Jan 22, 2020

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Jan 22, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 51.919% when pulling d419049 on MQE-1959 into fa4cbe2 on develop.

tomreece
tomreece suggested changes Jan 23, 2020
View reviewed changes
tomreece
tomreece approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@tomreece tomreece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jilu1 jilu1 merged commit c069eca into develop Jan 24, 2020
@jilu1 jilu1 deleted the MQE-1959 branch February 6, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomreece tomreece tomreece approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jilu1 @coveralls @tomreece