Skip to content

MQE-1765: Introduce API Endpoint and Request Headers to Allure artifacts #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 25, 2019
Merged

MQE-1765: Introduce API Endpoint and Request Headers to Allure artifacts #510

merged 4 commits into from
Nov 25, 2019

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Added allure artifacts + surrounding classes required to maintain uniqueness.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-1765: Introduce API Endpoint and Request Headers to Allure artifacts
3373f7d 
- Added new Allure event to MFTF codebase to prevent buggy allure behavior
- Changed calls to AllureHelper to use this new event
- Added calls to CurlHandler to add artifacts.
- Unit Test fix
@KevinBKozan
MQE-1765: Introduce API Endpoint and Request Headers to Allure artifacts
b5ea617 
- static check fix
@KevinBKozan
MQE-1765: Introduce API Endpoint and Request Headers to Allure artifact
44bd4bd 
- PHPUnit test fix
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 53.604% when pulling 44bd4bd on MQE-1765 into f101b0e on develop.

@coveralls
Copy link

coveralls commented Nov 20, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 52.354% when pulling fc1630f on MQE-1765 into 4e7467e on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 53.604% when pulling 44bd4bd on MQE-1765 into f101b0e on develop.

@tomreece
Copy link
Contributor

tomreece commented Nov 25, 2019 •
edited
Loading

Build:
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/26991/

The above build looks good. It has known MSI failures.
But I am able to see the API Endpoint and Headers.

Looks good to me.

@tomreece tomreece merged commit cf353e4 into develop Nov 25, 2019
@tomreece tomreece deleted the MQE-1765 branch December 11, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomreece tomreece tomreece approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBKozan @coveralls @tomreece