Skip to content

MQE-1470: add interface to handle file path and url format #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 26, 2019
Merged

MQE-1470: add interface to handle file path and url format #509

merged 6 commits into from
Nov 26, 2019

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Nov 20, 2019

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Nov 20, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 53.38% when pulling ecf1f25 on MQE-1470 into cf353e4 on develop.

@jilu1 jilu1 force-pushed the MQE-1470 branch 2 times, most recently from 3e5fa15 to 142a12d Compare November 20, 2019 19:08
tomreece
tomreece approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@tomreece tomreece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jilu1 jilu1 merged commit e4499a3 into develop Nov 26, 2019
@jilu1 jilu1 deleted the MQE-1470 branch February 6, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan left review comments

@tomreece tomreece tomreece approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jilu1 @coveralls @tomreece @KevinBKozan