Skip to content

MQE-1257: MFTF Doctor command #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 19, 2019
Merged

MQE-1257: MFTF Doctor command #500

merged 9 commits into from
Nov 19, 2019

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Oct 30, 2019

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Oct 30, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-1.2%) to 52.157% when pulling de359cb on MQE-1257 into 6c13d9d on develop.

okolesnyk
okolesnyk requested changes Nov 7, 2019
View reviewed changes
okolesnyk
okolesnyk requested changes Nov 7, 2019
View reviewed changes
Copy link
Member

@okolesnyk okolesnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add verification that you can open and access Magento storefront and Magento admin panel via browser.

@jilu1
Copy link
Contributor Author

jilu1 commented Nov 7, 2019

Please add verification that you can open and access Magento storefront and Magento admin panel via browser.

The current implementation has already implicitly checked the connectivity to selenium (the ability to launch the browser) and Magento admin credentials. Do we still need to launch the browser to targeted urls?

@jilu1
MQE-1257: MFTF doctor command
4908777 
- config color for console output
okolesnyk
okolesnyk reviewed Nov 18, 2019
View reviewed changes
docs/commands/mftf.md Outdated

#### Description

Diagnose MFTF configuration and setup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add more description.
Make it more descriptive.
Like:
Command is checking Selenium is up and running
Selenium available for MFTF
Verify that new session of browser can access magento instance
MagentoCLI command setup properly
etc...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

okolesnyk
okolesnyk reviewed Nov 18, 2019
View reviewed changes
src/Magento/FunctionalTestingFramework/Console/DoctorCommand.php Outdated
Comment on lines 27 to 30
const COLOR_LIGHT_GREEN = "\e[1;32m";
const COLOR_LIGHT_RED = "\e[1;31m";
const COLOR_LIGHT_DEFAULT = "\e[1;39m";
const COLOR_RESTORE = "\e[0m";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove those constants and make use of \Symfony\Component\Console\Style\SymfonyStyle class.
here is more info how it work: https://symfony.com/doc/current/console/style.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed. However, the code does style the output but there is no color change in my environment.

okolesnyk
okolesnyk requested changes Nov 18, 2019
View reviewed changes
Copy link
Member

@okolesnyk okolesnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I install MFTF standalone all checks works fine.
But with embedded edition they fail.
Please check what can be wrong.

@jilu1
Copy link
Contributor Author

jilu1 commented Nov 18, 2019

Missed / in the embedded bootstrap file. Fixed.

@jilu1 jilu1 changed the title MQE-1257: MFTF Troubleshoot command MQE-1257: MFTF Doctor command Nov 19, 2019
@jilu1 jilu1 merged commit f101b0e into develop Nov 19, 2019
@jilu1 jilu1 deleted the MQE-1257 branch February 6, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okolesnyk okolesnyk okolesnyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jilu1 @coveralls @okolesnyk