Skip to content

MQE-1782 #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 30, 2019
Merged

MQE-1782 #497

merged 7 commits into from
Oct 30, 2019

Conversation

KevinBKozan
Copy link
Contributor

Description

  • WIP

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

tomreece and others added 4 commits October 18, 2019 13:28
@tomreece
Work in progress before vacation
b7ee3f8
@KevinBKozan
MQE-1782: MFTF run:group can't run test in a suite
d8c58af 
- Added unit test template for test/suite configuration method
@KevinBKozan
MQE-1782: MFTF run:group can't run test in a suite
8e7494d 
- Moved group config function to BaseGenerateCommand
- Added more unit tests
@KevinBKozan
MQE-1782: MFTF run:group can't run test in a suite
09d8bfd 
- Removed old or unused code from implementation
- Added unit tests
@coveralls
Copy link

coveralls commented Oct 28, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 52.607% when pulling 8016574 on MQE-1782 into c3f7c05 on develop.

@tomreece
Copy link
Contributor

tomreece commented Oct 28, 2019 •
edited
Loading

Small edge case that we discussed...

If you have:

A suite named SomeSuite contains tests: TestOne, TestTwo, and TestThree
AND TestOne is also in some_group

And you run:

run:group SomeSuite some_group

Then the current implementation will only run TestOne because of the way it gets added to the result['suites'][suiteNameHere][] array

@KevinBKozan
MQE-1782: MFTF run:group can't run test in a suite
2a9df73 
- Fixed mixed group/suite usecase
- Added Unit test
@KevinBKozan
MQE-1782: MFTF run:group can't run test in a suite
9cb452b 
- changed from isset to array_search
- fixed static check
tomreece
tomreece approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@tomreece tomreece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@KevinBKozan KevinBKozan merged commit 640c2c9 into develop Oct 30, 2019
@KevinBKozan KevinBKozan deleted the MQE-1782 branch December 6, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomreece tomreece tomreece approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBKozan @coveralls @tomreece