Mqe 1650 Update MFTF configuration to read Test entities from new location

[jilu1]

Description

Fixed Issues (if relevant)

1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
2. ...

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/verification tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)
• Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

[coveralls]

Coverage increased (+0.9%) to 53.721% when pulling 83c3fbd on MQE-1650-2 into 17082a1 on develop.

[okolesnyk]

Why did you removed Magento_ from module name ?

[jilu1]

These are plain white list module paths. They should not be assumed to be magento module to match based on current logic

[KevinBKozan]

From my reviewing it seems Magento_Module format is still usable for .env since it merges to an existing list of Magento_Module formatted modules.

@jilu1 do either format work based on your implementation? I think the biggest concern here is backward compatibility.

[jilu1]

Before the change, these modules are not found by the ModuleResolver because they did not follow the search pattern.
After change, we search this path specifically. And they are in white list so it will be included.

[KevinBKozan]

Accidentally approved in above

[KevinBKozan]

Gave up on different approach, focused on trimming unecessary aspect of current approach. Please let me know if you need any clarification!

[KevinBKozan]

Function can be simplified:

        $shortenedPath = dirname(dirname($path));
        if (empty($path)) {
            return '';
        }
        foreach ($this->testModulePaths as $key => $value) {
            if ($value == $shortenedPath) {
                return $key;
            }
        }
        return '';

[jilu1]

Your code will need more checks as well. like what if depth of $path is shorter than 3. let's discuss in person

[KevinBKozan]

Small refactor for legibility:

            $regex = '~/' . $dirPath . '/([^/]+)~';
            // Escape directory separators
            $regex = str_replace('/', '\/', $regex);
            preg_match($regex, $path, $match);
            if (isset($match[1])) {
                $possibleVendorName = ucfirst($match[1]);
                break;
            }

What do you think?

[jilu1]

Let's discuss in person

[KevinBKozan]

One small response about a conditional. Continuing on QAing it though.

[KevinBKozan]

No BIC changes detected, approved 👍