Skip to content

MQE-837: Assert sub-elements can't be declared out of sequence #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 2, 2018
Merged

MQE-837: Assert sub-elements can't be declared out of sequence #44

merged 4 commits into from
Mar 2, 2018

Conversation

KevinBKozan
Copy link
Contributor

@KevinBKozan KevinBKozan commented Mar 2, 2018 •
edited
Loading

Description

  • Changed schema to allow for above
  • Added validation in lieu of xsd validation.

Fixed Issues (if relevant)

  1. Eliminated Aspect Mock usage from ActionMergeUtilTest #837: Assert sub-elements can't be declared out of sequence

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-837: Assert sub-elements can't be declared out of sequence.
0eb1613 
- changed sequence -> choice in schema for assert actions.
@KevinBKozan
MQE-837: Assert sub-elements can't be declared out of sequence.
2a3ac3e 
- changed maxOccurs to fix verification test
@KevinBKozan
MQE-837: Assert sub-elements can't be declared out of sequence.
d431d3c 
- added check for correct schema in actionObject, in lieu of schema validation due to backwards compatibility
@KevinBKozan
MQE-837: Assert sub-elements can't be declared out of sequence.
425c761 
- CR fixes.
@KevinBKozan KevinBKozan merged commit 64972b3 into develop Mar 2, 2018
@KevinBKozan KevinBKozan deleted the MQE-837 branch March 2, 2018 14:25
magento-cicd2 pushed a commit that referenced this pull request Mar 31, 2021
@jilu1
Merge pull request #44 from magento-commerce/imported-magento-magento…
67173dc 
…2-functional-testing-framework-816

[Imported] Update mftf.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KevinBKozan