Skip to content

MQE-588: CreatedData should throw Error/Warning when undefined data i… #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 5, 2019
Merged

MQE-588: CreatedData should throw Error/Warning when undefined data i… #432

merged 6 commits into from
Sep 5, 2019

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Aug 27, 2019

…s returned

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Aug 27, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 51.974% when pulling a708d46 on MQE-558 into a233e32 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 52.792% when pulling 4d46f9b on MQE-558 into 3c7ed4b on develop.

@soumyau soumyau self-requested a review August 29, 2019 19:57
soumyau
soumyau suggested changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see build failures in - https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/23345/ due to expections like this: Undefined field default_value in entity object with a stepKey of createConfigProductAttribute. Please verify

@jilu1
MQE-588: CreatedData should throw Error/Warning when undefined data i…
d4a1237 
…s returned

- changed to print warning message for backward compatibility
soumyau
soumyau reviewed Aug 30, 2019
View reviewed changes
...s/unit/Magento/FunctionalTestFramework/DataGenerator/Handlers/PersistedObjectHandlerTest.php Outdated

// validate log statement
TestLoggingUtil::getInstance()->validateMockLogStatement(
"warning",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe change double quotes to single? Not the end of the world, but read that it avoids processing overhead for strings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

soumyau
soumyau suggested changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very small change + latest UR build results. Looks good with local runs!

@jilu1
Copy link
Contributor Author

jilu1 commented Sep 4, 2019

I see build failures in - https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/23345/ due to expections like this: Undefined field default_value in entity object with a stepKey of createConfigProductAttribute. Please verify

Updated mainline and get green build https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/23527/

soumyau
soumyau approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jilu1 jilu1 merged commit 167c7e7 into develop Sep 5, 2019
@jilu1 jilu1 deleted the MQE-558 branch September 17, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumyau soumyau soumyau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jilu1 @coveralls @soumyau