Skip to content

MQE-1705: Fix PHP Notice in Unit Test #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2019
Merged

MQE-1705: Fix PHP Notice in Unit Test #426

merged 2 commits into from
Aug 22, 2019

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Fixed potential bug in EntityDataObject

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan KevinBKozan requested a review from tomreece August 20, 2019 19:54
@coveralls
Copy link

coveralls commented Aug 20, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 52.176% when pulling ac1f5bf on MQE-1705 into f9d5fe4 on develop.

jilu1
jilu1 approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@KevinBKozan KevinBKozan merged commit 12f9596 into develop Aug 22, 2019
@KevinBKozan KevinBKozan deleted the MQE-1705 branch August 22, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomreece tomreece tomreece approved these changes

@jilu1 jilu1 jilu1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KevinBKozan @coveralls @tomreece @jilu1