Skip to content

MQE-1373: Cannot Use Data Returned By Test Actions As Substitutable V… #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 21, 2019
Merged

MQE-1373: Cannot Use Data Returned By Test Actions As Substitutable V… #424

merged 3 commits into from
Aug 21, 2019

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Aug 19, 2019 •
edited
Loading

to replace custom field key in create data
fixed regex to include action group parameter references
fixed test generator to make full word replacement of stepKey references

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@soumyau
MQE-1373: Cannot Use Data Returned By Test Actions As Substitutable V…
932c435 
…alue Inside Parameterized Selector From Within Action Group

to replace custom field key in create data
fixed regex to include action group parameter references
fixed test generator to make full word replacement of stepKey references
@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.867% when pulling 932c435 on MQE-1373 into a626fb8 on develop.

@coveralls
Copy link

coveralls commented Aug 19, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-1.6%) to 52.176% when pulling 6a1fac6 on MQE-1373 into 3a73b31 on develop.

@soumyau
Copy link
Contributor Author

soumyau commented Aug 19, 2019 •
edited
Loading

build passed except for extensions - https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/23002/

@KevinBKozan KevinBKozan self-requested a review August 20, 2019 14:44
KevinBKozan
KevinBKozan reviewed Aug 20, 2019
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a small comment + verification tests, otherwise fix looks good!

@soumyau
MQE-1373: Cannot Use Data Returned By Test Actions As Substitutable V…
36c21d3 
…alue Inside Parameterized Selector From Within Action Group

to replace custom field key in create data
added verification test + comments
soumyau
soumyau commented Aug 20, 2019
View reviewed changes
Copy link
Contributor Author

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a small comment + verification tests, otherwise fix looks good!

done!

@soumyau soumyau merged commit f9d5fe4 into develop Aug 21, 2019
@jilu1 jilu1 deleted the MQE-1373 branch February 6, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soumyau @coveralls @KevinBKozan