Skip to content

MQE-1306: Can not get actual entity data #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2019
Merged

MQE-1306: Can not get actual entity data #406

merged 1 commit into from
Aug 6, 2019

Conversation

tomreece
Copy link
Contributor

@tomreece tomreece commented Aug 1, 2019

Description

Fixes bug MQE-1306 by adding a fallback checking for camelCaseKeys in data if now lowercasekeys are found.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 54.519% when pulling b1adef4 on MQE-1306 into 656f819 on develop.

KevinBKozan
KevinBKozan suggested changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are close but I think they need a little bit of work on a single line.

The unsuredness is because I'm not 100% sure on the usecase.

@tomreece tomreece merged commit 85c14a0 into develop Aug 6, 2019
@tomreece tomreece deleted the MQE-1306 branch September 3, 2019 16:31
magento-devops-reposync-svc pushed a commit that referenced this pull request Jun 25, 2024
@KevinBKozan
Merge pull request #406 from magento-gl/ACQE-6716
f43763f 
ACQE-6716 | Unneeded reports are shown when MFTF Static tests fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomreece @coveralls @KevinBKozan