Skip to content

MQE-1672: AllureAdapter does not output BROKEN test steps #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 26, 2019

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Fixed broken steps not showing up at all
  • Fixed ActionGroup nesting issues when the test abruptly ends

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Jul 26, 2019

Coverage Status

Coverage increased (+1.6%) to 56.119% when pulling 1b60a53 on MQE-1672 into 5c7bea5 on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.119% when pulling 2f7ae70 on MQE-1672 into 95b1eec on develop.

Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise looks good.

$failStep = new Step();
$failStep->setName("ERROR");
$failStep->setTitle($message);
$failStep->setStatus(Status::BROKEN);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the BROKEN status accurate?

Copy link
Contributor Author

@KevinBKozan KevinBKozan Jul 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, yes. Class Status only has mappings for FAILED BROKEN PASSED CANCELED PENDING, so I think it makes sense.

Also, refer to AllureCodeception.php ln 339, you'll see two functions testError() and testFail().

  • testError() => hard error in test, like a fatal PHP error
  • testFail() => exception thrown in the test cause a true failure (not an error)

Based on that delinitation and mapping to Codeception's existing hooks I think it makes sense for this to be Status::BROKEN

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense.

Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Approve it.

@KevinBKozan KevinBKozan merged commit 3e8ee44 into develop Jul 26, 2019
@KevinBKozan KevinBKozan deleted the MQE-1672 branch July 26, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants