-
Notifications
You must be signed in to change notification settings - Fork 132
MQE-1672: AllureAdapter does not output BROKEN test steps #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Fixed broken steps not showing up at all - Fixed ActionGroup nesting issues when the test abruptly ends
- PHPMD Suppression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise looks good.
$failStep = new Step(); | ||
$failStep->setName("ERROR"); | ||
$failStep->setTitle($message); | ||
$failStep->setStatus(Status::BROKEN); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the BROKEN status accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, yes. Class Status
only has mappings for FAILED BROKEN PASSED CANCELED PENDING
, so I think it makes sense.
Also, refer to AllureCodeception.php
ln 339, you'll see two functions testError()
and testFail()
.
testError()
=> hard error in test, like a fatal PHP errortestFail()
=> exception thrown in the test cause a true failure (not an error)
Based on that delinitation and mapping to Codeception's existing hooks I think it makes sense for this to be Status::BROKEN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Approve it.
Description
Contribution checklist