-
Notifications
You must be signed in to change notification settings - Fork 132
Mqe 1647 Read vault token from file system #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rethink how readVaultTokenFromFileSystem
method works.
It relying on UNIX console commands which will fail on Windows machine.
If ENV HOME is not available read from .env
and do not overcomplicate the logic.
I do suggest to use native PHP functions to read it.
src/Magento/FunctionalTestingFramework/DataGenerator/Handlers/SecretStorage/VaultStorage.php
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/DataGenerator/Handlers/SecretStorage/VaultStorage.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/DataGenerator/Handlers/SecretStorage/VaultStorage.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/DataGenerator/Handlers/SecretStorage/VaultStorage.php
Outdated
Show resolved
Hide resolved
src/Magento/FunctionalTestingFramework/DataGenerator/Handlers/SecretStorage/VaultStorage.php
Outdated
Show resolved
Hide resolved
Had discussion in person and addressed issues we agreed upon. |
@jilu1 please resolve merge conflicts and I think this ticket is good to go. |
It's based on previous develop where we have the other vault story in place. Now it's been reverted and thus the merge conflict. I think i will wait for 2.4.3 tag cut. |
Combined in PR #410 |
Description
Fixed Issues (if relevant)
Contribution checklist