Skip to content

MQE-1639: [DEVDOCS] Best Practices for including HTML Source in Tests #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 24, 2019
Merged

MQE-1639: [DEVDOCS] Best Practices for including HTML Source in Tests #390

merged 7 commits into from
Jul 24, 2019

Conversation

tomreece
Copy link
Contributor

Description

Add content to devdocs about encoding HTML for use in tests.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@tomreece
MQE-1639: [DEVDOCS] Best Practices for including HTML Source in Tests
b8b4d25 
- Add content about encoding HTML for use in tests
@tomreece tomreece requested review from ivy00johns and dobooth July 23, 2019 18:54
@coveralls
Copy link

coveralls commented Jul 23, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 53.381% when pulling afeef28 on MQE-1639 into 4212ad6 on develop.

dobooth
dobooth previously approved these changes Jul 23, 2019
View reviewed changes
@dobooth dobooth added the DOC label Jul 23, 2019
lbajsarowicz
lbajsarowicz previously approved these changes Jul 24, 2019
View reviewed changes
@tomreece
Copy link
Contributor Author

I think I missed an action: dontSeeInPageSource

I'll add the same comment for this action too.

@tomreece
MQE-1639: [DEVDOCS] Best Practices for including HTML Source in Tests
da75a64 
- Make sure all 4 actions are consistently worded
@tomreece tomreece dismissed stale reviews from lbajsarowicz and dobooth via da75a64 July 24, 2019 16:18
@ivy00johns
Copy link
Contributor

Looks good to me!

ivy00johns
ivy00johns approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@ivy00johns ivy00johns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tomreece tomreece merged commit de22277 into develop Jul 24, 2019
@tomreece tomreece deleted the MQE-1639 branch July 24, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivy00johns ivy00johns ivy00johns approved these changes

@lbajsarowicz lbajsarowicz lbajsarowicz left review comments

@dobooth dobooth dobooth left review comments

Assignees
No one assigned
Labels
DOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomreece @coveralls @ivy00johns @lbajsarowicz @dobooth