Skip to content

added file name suffix principle for data #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2019
Merged

added file name suffix principle for data #374

merged 1 commit into from
Jun 27, 2019

Conversation

sprankhub
Copy link
Member

Description

MFTF will only read data nodes from files, which have the suffix Data.xml. I did not find a place where this is documented and I think it fits here.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-cicd2
Copy link

magento-cicd2 commented Jun 25, 2019

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Jun 25, 2019

Coverage Status

Coverage decreased (-1.6%) to 54.395% when pulling 098bc0d on sprankhub:patch-1 into 9b5de03 on magento:master.

@KevinBKozan
Copy link
Contributor

@sprankhub thank you for the contribution! I'll request a review from @dobooth as this is a doc-only PR.

@KevinBKozan KevinBKozan requested a review from dobooth June 25, 2019 14:01
@KevinBKozan KevinBKozan merged commit a850051 into magento:master Jun 27, 2019
@sprankhub sprankhub deleted the patch-1 branch June 27, 2019 20:43
magento-devops-reposync-svc pushed a commit that referenced this pull request Jan 4, 2024
ACQE-5886 : UNIT Tests  for Functional build with PTS enabled executes tests that should be excluded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants