Skip to content

MQE-1580 - [DOCUMENTATION] Remove the "page" attribute from the Action Group annotations node. #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 13, 2019

Conversation

ivy00johns
Copy link
Contributor

@ivy00johns ivy00johns commented Jun 6, 2019

MQE-1580

Description

  • Removed the <page> annotation from the Action Group <annotations> scheme so it is no longer required.
  • Removed the test for the <page> annotation from the mftf generate:docs command.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

ivy00johns and others added 12 commits May 31, 2019 13:57
…ns node.

- Removed the "page" attribute from the annotations block.
…ns node.

- Removed the "page" from the Required Annotations XML Scheme test.
…ns node.

- Removing the remaining Action Group "Page" references from the code base.
…ns node.

- Correcting the expected Text in the Test.
…ns node.

- Correcting the expected Text in the Test.
…ns node.

- Correcting the expected Text in the Static Test.
…ns node.

- Correcting the expected Text in the Static Test.
…ns node.

- Correcting the expected Text in the Static Test.
…ns node.

- Correcting the expected Text in the Static Test.
…ns node.

- Correcting the expected Text in the Static Test.
…ns node.

- Correcting the expected Text in the Static Test.
@soumyau
Copy link
Contributor

soumyau commented Jun 11, 2019

@soumyau soumyau self-requested a review June 11, 2019 16:02
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please fix phpunit failures.

@ivy00johns
Copy link
Contributor Author

I finally got the Unit Test resolved.

@ivy00johns ivy00johns requested a review from soumyau June 12, 2019 14:22
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 54.455% when pulling fcecdd4 on MQE-1580 into 41caa75 on develop.

@coveralls
Copy link

coveralls commented Jun 12, 2019

Coverage Status

Coverage decreased (-1.5%) to 54.455% when pulling fcecdd4 on MQE-1580 into 41caa75 on develop.

@soumyau soumyau merged commit 46d0de1 into develop Jun 13, 2019
@jilu1 jilu1 deleted the MQE-1580 branch February 6, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants