-
Notifications
You must be signed in to change notification settings - Fork 132
MQE-1580 - [DOCUMENTATION] Remove the "page" attribute from the Action Group annotations node. #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns node. - Removed the "page" attribute from the annotations block.
…ns node. - Removed the "page" from the Required Annotations XML Scheme test.
…ns node. - Removing the remaining Action Group "Page" references from the code base.
…ns node. - Correcting the expected Text in the Test.
…ns node. - Correcting the expected Text in the Test.
…ns node. - Correcting the expected Text in the Static Test.
…ns node. - Correcting the expected Text in the Static Test.
…ns node. - Correcting the expected Text in the Static Test.
…ns node. - Correcting the expected Text in the Static Test.
…ns node. - Correcting the expected Text in the Static Test.
…ns node. - Correcting the expected Text in the Static Test.
phpunit checks failed, please fix https://github.com/magento/magento2-functional-testing-framework/pull/360/checks?check_run_id=145247206 |
soumyau
suggested changes
Jun 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please fix phpunit failures.
- Removing "updateData", does NOT contain a <field>.
…ns node. - Correct unit test text.
…ns node. - Fixed the Unit Test finally.
I finally got the Unit Test resolved. |
soumyau
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MQE-1580
Description
<page>
annotation from the Action Group<annotations>
scheme so it is no longer required.<page>
annotation from themftf generate:docs
command.Contribution checklist