Skip to content

MQE-685: References to ENV file must be done at test run-time #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 8, 2018

Conversation

KevinBKozan
Copy link
Contributor

@KevinBKozan KevinBKozan commented Feb 7, 2018

Description

{{_ENV.value}} references are no longer done on generation; they are done in test runtime. This fixes the issue of Magento instances changing .env contents post generation in builds.

Fixed Issues

  1. magento/magento2-functional-testing-framework#<685>: References to ENV file must be done at test run-time

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan KevinBKozan merged commit 4c3cdf1 into develop Feb 8, 2018
@KevinBKozan KevinBKozan deleted the MQE-685 branch February 8, 2018 21:03
magento-cicd2 pushed a commit that referenced this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant