Allow the webdriver to directly call upon the 'bin/magento' executable

[powli]

Description

Allows the MagentoWebDriver to directly call the bin/magento executable instead of performing CURL requests to the custom command.php endpoint. Falls back to the custom endpoint upon exception

Fixed Issues (if relevant)

1. magentoCLI actions not working if docroot points to /pub #339: magentoCLI actions not working if docroot points to /pub

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/verification tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)
• Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

[coveralls]

Coverage remained the same at 56.212% when pulling 1b264ee on netresearch:CLI-direct-shell-exec into f6b64c8 on magento:develop.

[coveralls]

Coverage increased (+0.2%) to 52.381% when pulling bdd0735 on netresearch:CLI-direct-shell-exec into f110875 on magento:develop.

[KevinBKozan]

@powli thank you for yoru contribution! I'll create an internal ticket to track progress on processing your PR, we will keep you updated as we make further progress on it.

[soumyau]

@powli This PR needs an Adobe CLA, can you please sign it? Also, I see some merge conflicts can you resolve them as well?

[soumyau]

@powli
Implementation looks good, running UR builds.

There are conflicts in the branch to be resolved + Adobe CLA needs to be signed. Thanks for your submission!

[okolesnyk]

Hi @powli
Sorry for closing and reopening your PR, but I had to do it to re-trigger Adobe CLA check.
Please sign it as soon as you can, cause otherwise we wont be able to merge your changes :-(

[soumyau]

Resolved conflicts on the branch via GitHub UI. However, the PR is still unmergable due to missing Adobe CLA.

[powli]

@okolesnyk, @soumyau Signed the Adobe CLA and updated the branch (I think).

[soumyau]

UR build: https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/25625/
No failures introduced by this PR.
Nice work!

[soumyau]

Hi @powli We noticed pipeline timeouts in our jenkins builds with this change, specifically with cron:run commands hanging containers endlessly waiting for queue:consumers:start processes to finish. Devops is investigating this issue, will keep you posted. After an internal discussion about the best way to proceed, we are reverting the changes introduced by this PR for the upcoming release 2.5.4. Meanwhile if you have encountered similar issues, do let us know.

[tomreece]

Hi @powli

This change has been problematic for us and our internal CICD pipeline.
This is causing us to discuss the original use-case for your change and whether it actually helps a lot of people or not.

You mention issue #339 but I think the correct solution to #339 is to tweak the NGINX configuration the same way we have to tweak the htaccess file for Apache.
This is the preffered solution to #339 and we should document this better in DEVDOCS.

Am I missing something about your original intention?

[powli]

Hey @tomreece, @soumyau,

In #339 I already mentioned activating this feature via configuration (either on CLI or functional.suite.yml, see #339 (comment)).

That would probably resolve your CICD issues, depending on where they occur. Tell me if you're interested, then I can see where I find the time. Otherwise do as you wish ;)

The original intention was avoiding the HTTP overhead by just running the commands natively, I think. It's been some time.