Skip to content

Adding 2 tips to Tips and Tricks. #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 25, 2019

Conversation

dobooth
Copy link
Contributor

@dobooth dobooth commented Apr 22, 2019

Description

Adding two new tips to the Tips and Tricks page.

  • Use data references to avoid hardcoded values
  • Use contains() around text()

https://devdocs.magento.com/mftf/docs/tips-tricks.html

@dobooth dobooth added the DOC label Apr 22, 2019
@dobooth dobooth self-assigned this Apr 22, 2019
@dobooth dobooth requested review from erikmarr and tomreece April 22, 2019 15:45
@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.991% when pulling 31cc212 on magento-devdocs:db_tipstricks into c9dd418 on magento:develop.

@coveralls
Copy link

coveralls commented Apr 22, 2019

Coverage Status

Coverage remained the same at 56.212% when pulling b17e99b on magento-devdocs:db_tipstricks into 31adf3c on magento:develop.

Copy link
Contributor

@tomreece tomreece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than a small typo.

`contains()` ignores whitespace while `text()` accounts for it.

**Why?**
If you are comparing text wihtin a selector and have an unexpected space, or a blank line above or below the string, `text()` will fail while the `contains(text())` format will catch it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: wihtin should be within

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye.

@KevinBKozan KevinBKozan merged commit 38e5a69 into magento:develop Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants