Skip to content

Moving MFTF docs into this repo. #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 21, 2019
Merged

Conversation

dobooth
Copy link
Contributor

@dobooth dobooth commented Mar 8, 2019

Description

This PR will move the MFTF docs from the usual devdocs repo into the MFTF repo.
This will allow contributors to easily add docs at the same time they add code submissions.

Fixed up links.
Liquid tags removed except for {% raw %} which are needed for code samples.
TOC will up updated from the main devdocs repo.

@magento-cicd2
Copy link

magento-cicd2 commented Mar 8, 2019

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Mar 9, 2019

Coverage Status

Coverage increased (+0.008%) to 57.062% when pulling cb5a2ba on magento-devdocs:db_mftfdocs into db370cf on magento:develop.

Copy link
Member

@okolesnyk okolesnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dobooth
Can you add Readme.MD to docs folder with some kind of navigation trough all of the docs we have.

@dshevtsov
Copy link
Contributor

@okolesnyk it would make sense to keep the README at the root to make it easier to find. In the docs/ folder it will be less visible among other .md files. Also, we do not plan to publish it on devdocs considering the current informational structure of the documentation to publish.

okolesnyk
okolesnyk previously approved these changes Mar 19, 2019
@okolesnyk
Copy link
Member

Copy link
Contributor

@dshevtsov dshevtsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace .html with .md in all internal links to enable the hyperlinks to work on GitHub UI.

Also, see suggested changes in different files.

See the license [here][] or contact [license@magentocommerce.com][] for a copy.

<!-- Link Definitions -->
[Getting Started]: https://devdocs.magento.com/mftf/getting-started.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convert to relative link

@okolesnyk okolesnyk merged commit 4fc3430 into magento:develop Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants