Skip to content

MQE-1178: MFTF Generate:Suite Does Not Generate Extended Items Correctly #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2018

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Nov 6, 2018

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Nov 6, 2018

Coverage Status

Coverage increased (+0.008%) to 57.4% when pulling 429d59e on MQE-1178 into ecac043 on develop.

@@ -110,7 +110,7 @@ public function getTestsByGroup($groupName)
foreach ($this->tests as $test) {
/** @var TestObject $test */
if (in_array($groupName, $test->getAnnotationByName('group'))) {
$relevantTests[$test->getName()] = $test;
$relevantTests[$test->getName()] = $this->extendTest($test);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we can add a verification test for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly. I will look into it.

@magento-engcom-team magento-engcom-team deleted the MQE-1178 branch November 9, 2018 11:29
@VladimirZaets VladimirZaets restored the MQE-1178 branch November 9, 2018 13:59
@VladimirZaets VladimirZaets reopened this Nov 9, 2018
@jilu1 jilu1 merged commit bf7ea22 into develop Nov 14, 2018
@jilu1 jilu1 deleted the MQE-1178 branch November 14, 2018 17:09
magento-devops-reposync-svc pushed a commit that referenced this pull request Feb 6, 2023
ACQE-4538: Allow mftf generate minimum possible groups runnable by co…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants