MQE-661 #26
Merged
MQE-661 #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created text file, changes to dom.php and di.xml to accomodate new txt file.
- removed | from txt file, replacement replaces \n with | to account for it.
- $_ENV to getenv()
- Code Review changes.
|
I will squash and merge to get rid of all of these commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break out common test actions from di.xml
Description
All test actions that are common between before/after/test/action-group are now an entity declared at the top of di.xml. If actions are added to this list, they now can only be added to one list instead of six.
Fixed Issues
Contribution checklist