MQE-1185: MFTF DragAndDrop Action Is Not Using X, Y Offsets Correctly

[jilu1]

• bug fix

Description

Fixed Issues (if relevant)

1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
2. ...

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/verification tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)
• Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

[coveralls]

Coverage increased (+0.008%) to 57.4% when pulling 8600e8b on MQE-1185 into c53b77a on develop.

[KevinBKozan]

I'm not 100% sure what this code change accomplishes. dragAndDropBy does each of the individual $action->action()->perform() so I'm not 100% sure how this could fix anything? Was the proposed usecase fixed by this tweak?

[jilu1]

Yes, this fix did the trick for the reported use case. I do not know why the previous one did not work.

[KevinBKozan]

I ran builds using this change, and I found that there are three tests that fail consistently across builds after the drag and drop change (link sent via DM).

We shouldn't change functionality in a way that breaks tests in a minor/patch release, so if you can find a way to make those tests work with both your new and old drag and drops (and check it in, so the MFTF version bump doesn't break them) we can include this in our next minor.

[KevinBKozan]

Tests no longer failing, I don't love the conditional but the changes work.