Skip to content

MQE-1256: "Merge" works different for tests and action groups #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Actiongroup and test dom classes now check for duplicate child and elements.
  • Minor bugfix around searching filename, "test" is literally always going to appear in filepath due to directory structure.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

- Actiongroup and test dom classes now check for duplicate child <test> and <actionGroup> elements.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 57.524% when pulling 53a0f69 on MQE-1256-2 into de1ab89 on develop.

@KevinBKozan KevinBKozan merged commit 94afc74 into develop Sep 27, 2018
@KevinBKozan KevinBKozan deleted the MQE-1256-2 branch September 27, 2018 20:21
magento-devops-reposync-svc pushed a commit that referenced this pull request Oct 27, 2022
ACQE-4111 : Merging master back to develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants