Skip to content

MAGEDOC-3161: Create CONTRIBUTING.md #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2018

Conversation

dshevtsov
Copy link
Contributor

Copy content from devdocs
Convert to GFM
Review and update
Add table of contents

Description

Add CONTRIBUTING.md with the guidelines from the corresponding devdocs topic to follow the common GitHub recommendations and the magento2 repo structure.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

Copy content from devdocs
Convert to GFM
Review and update
Add table of contents
@magento-cicd2
Copy link

magento-cicd2 commented Sep 20, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.398% when pulling b8c6d22 on magento-devdocs:MAGEDOC-3161 into 67af7e0 on magento:develop.

@coveralls
Copy link

coveralls commented Sep 20, 2018

Coverage Status

Coverage increased (+0.1%) to 57.516% when pulling c698f27 on magento-devdocs:MAGEDOC-3161 into 67af7e0 on magento:develop.

The typical way is discussed in the [Syncing a fork][github sync fork] GitHub article.
Make sure to update from the correct branch!

The othger way is to create a reverse pull request from the original repository.
Copy link
Contributor

@aljcalandra aljcalandra Oct 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo for other

aljcalandra
aljcalandra previously approved these changes Oct 1, 2018
Copy link
Contributor

@aljcalandra aljcalandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the one comment on the file.
You may want to wait for another review or two aside from mine.

@dshevtsov
Copy link
Contributor Author

@aljcalandra
I fixed the typo along with some formatting.

@dshevtsov dshevtsov mentioned this pull request Oct 1, 2018
5 tasks
@KevinBKozan KevinBKozan merged commit 0a3ef3a into magento:develop Oct 3, 2018
magento-devops-reposync-svc pushed a commit that referenced this pull request Nov 2, 2022
…ope_04102022

[Hammer]_platform_health_246_scope_04102022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants