Skip to content

MQE-1153: ExecuteJS javascript escaping matches persisted data #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2018

Conversation

aljcalandra
Copy link
Contributor

ExecuteJS should now properly escape sequences without involving persisted data

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

- Updated Regular expression for executeJS to be stricter for escaping characters
- Updated regex to support an additional use case
- Added test for additional use case
@coveralls
Copy link

coveralls commented Aug 3, 2018

Coverage Status

Coverage remained the same at 56.165% when pulling a6bc047 on MQE-1153 into df6aaf9 on develop.

@aljcalandra aljcalandra merged commit 0d8189d into develop Aug 3, 2018
@aljcalandra aljcalandra deleted the MQE-1153 branch August 3, 2018 17:09
magento-devops-reposync-svc pushed a commit that referenced this pull request May 9, 2022
MQE-3096 : unit tests for GenerateTestFailedCommandTest and RunTestFailed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants