Skip to content

MQE-1151: Extending a skipped test fails to generate the parent before and after actions #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2018

Conversation

aljcalandra
Copy link
Contributor

This change will allow before and after hooks to be generated for an extended test when those hoooks live on the parent test and that parent test is skipped.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

…e and after actions

- Added parameter to getHooks to return the hooks if the value is true
- Added a verification test for the topic
…e and after actions

- Removing paramater from getHooks
- Adding test for hooks generation on skipped test
- Moving skipped logic to testGenerator
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 56.165% when pulling 2b991cb on MQE-1151 into 659cca0 on develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 56.165% when pulling 2b991cb on MQE-1151 into 659cca0 on develop.

@coveralls
Copy link

coveralls commented Jul 31, 2018

Coverage Status

Coverage remained the same at 56.173% when pulling 2b991cb on MQE-1151 into 659cca0 on develop.

@aljcalandra aljcalandra merged commit df6aaf9 into develop Jul 31, 2018
@aljcalandra aljcalandra deleted the MQE-1151 branch July 31, 2018 16:34
magento-devops-reposync-svc pushed a commit that referenced this pull request May 5, 2022
MQE-3447: Remove any remaining usages of Travis CI from MFTF Repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants