Skip to content

MQE-1147: Turn Off Readiness Logging #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2018
Merged

MQE-1147: Turn Off Readiness Logging #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae109cd
Turning off all logging for Readiness Extension
KevinBKozan Jul 18, 2018
468502d
Merge branch 'develop' into TurnOffReadinessLogging
KevinBKozan Jul 18, 2018
d5348a0
MQE-1147: Turning off all logging for Readiness Extension
KevinBKozan Jul 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Magento/FunctionalTestingFramework/Extension/PageReadinessExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ private function shouldSkipCheck($step)
* @param string $message
* @param array $context
* @return void
* @SuppressWarnings(PHPMD)
*/
private function logDebug($message, $context = [])
{
Expand All @@ -264,7 +265,8 @@ private function logDebug($message, $context = [])
$logContext[$metric->getName() . '.failCount'] = $metric->getFailureCount();
}
$context = array_merge($logContext, $context);
$this->logger->info($message, $context);
//TODO REMOVE THIS LINE, UNCOMMENT LOGGER
//$this->logger->info($message, $context);
}
}
}
14 changes: 10 additions & 4 deletions src/Magento/FunctionalTestingFramework/Extension/ReadinessMetrics/AbstractMetricCheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ private function getCurrentValue($refresh = false)
*/
public function getStoredValue()
{
return $this->storedValue;
return $this->storedValue ?? null;
}

/**
Expand Down Expand Up @@ -306,11 +306,13 @@ public function resetTracker()
* @param string $message
* @param array $context
* @return void
* @SuppressWarnings(PHPMD)
*/
protected function errorLog($message, $context = [])
{
$context = array_merge($this->getLogContext(), $context);
$this->logger->error($message, $context);
//TODO REMOVE THIS LINE, UNCOMMENT LOGGER
//$this->logger->error($message, $context);
}

/**
Expand All @@ -319,11 +321,13 @@ protected function errorLog($message, $context = [])
* @param string $message
* @param array $context
* @return void
* @SuppressWarnings(PHPMD)
*/
protected function infoLog($message, $context = [])
{
$context = array_merge($this->getLogContext(), $context);
$this->logger->info($message, $context);
//TODO REMOVE THIS LINE, UNCOMMENT LOGGER
//$this->logger->info($message, $context);
}

/**
Expand All @@ -332,12 +336,14 @@ protected function infoLog($message, $context = [])
* @param string $message
* @param array $context
* @return void
* @SuppressWarnings(PHPMD)
*/
protected function debugLog($message, $context = [])
{
if ($this->verbose) {
$context = array_merge($this->getLogContext(), $context);
$this->logger->debug($message, $context);
//TODO REMOVE THIS LINE, UNCOMMENT LOGGER
//$this->logger->debug($message, $context);
}
}

Expand Down