Skip to content

MQE-231: Allow data to extend other data #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 5, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
use Magento\FunctionalTestingFramework\DataGenerator\Parsers\DataProfileSchemaParser;
use Magento\FunctionalTestingFramework\ObjectManager;
use Magento\FunctionalTestingFramework\ObjectManagerFactory;
use PHPUnit\Framework\TestCase;
use Magento\FunctionalTestingFramework\Util\MagentoTestCase;

/**
* Class DataObjectHandlerTest
*/
class DataObjectHandlerTest extends TestCase
class DataObjectHandlerTest extends MagentoTestCase
{
// All tests share this array, feel free to add but be careful modifying or removing
const PARSER_OUTPUT = [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@
use Magento\FunctionalTestingFramework\ObjectManagerFactory;
use Magento\FunctionalTestingFramework\DataGenerator\Handlers\OperationDefinitionObjectHandler;
use Magento\FunctionalTestingFramework\DataGenerator\Parsers\OperationDefinitionParser;
use PHPUnit\Framework\TestCase;
use Magento\FunctionalTestingFramework\Util\MagentoTestCase;

/**
* Class OperationDefinitionObjectHandlerTest
*/
class OperationDefinitionObjectHandlerTest extends TestCase
class OperationDefinitionObjectHandlerTest extends MagentoTestCase
{
public function testGetMultipleObjects()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

namespace Magento\FunctionalTestingFramework\DataGenerator\Objects;

use PHPUnit\Framework\TestCase;
use Magento\FunctionalTestingFramework\Util\MagentoTestCase;
use tests\unit\Util\TestLoggingUtil;

/**
Expand All @@ -33,7 +33,7 @@ function msqs($id = null)
/**
* Class EntityDataObjectTest
*/
class EntityDataObjectTest extends TestCase
class EntityDataObjectTest extends MagentoTestCase
{
/**
* Before test functionality
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@
use Magento\FunctionalTestingFramework\DataGenerator\Handlers\DataObjectHandler;
use Magento\FunctionalTestingFramework\DataGenerator\Handlers\OperationDefinitionObjectHandler;
use Magento\FunctionalTestingFramework\DataGenerator\Persist\OperationDataArrayResolver;
use PHPUnit\Framework\TestCase;
use Magento\FunctionalTestingFramework\Util\MagentoTestCase;
use tests\unit\Util\EntityDataObjectBuilder;
use tests\unit\Util\OperationDefinitionBuilder;
use tests\unit\Util\OperationElementBuilder;
use tests\unit\Util\TestLoggingUtil;

class OperationDataArrayResolverTest extends TestCase
class OperationDataArrayResolverTest extends MagentoTestCase
{
const NESTED_METADATA_EXPECTED_RESULT = ["parentType" => [
"name" => "Hopper",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,155 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

namespace Magento\FunctionalTestingFramework\DataGenerator\Objects;

use Magento\FunctionalTestingFramework\DataGenerator\Handlers\DataObjectHandler;
use Magento\FunctionalTestingFramework\DataGenerator\Parsers\DataProfileSchemaParser;
use Magento\FunctionalTestingFramework\ObjectManager\ObjectManager;
use Magento\FunctionalTestingFramework\ObjectManagerFactory;
use Magento\FunctionalTestingFramework\Util\MagentoTestCase;
use AspectMock\Test as AspectMock;

/**
* Class EntityDataObjectTest
*/
class EntityDataExtensionTest extends MagentoTestCase
{
/**
* Before method functionality
* @return void
*/
protected function setUp()
{
AspectMock::clean();
}

public function testNoParentData()
{
$extendedDataObject = [
'entity' => [
'extended' => [
'type' => 'testType',
'extends' => "parent",
'data' => [
0 => [
'key' => 'testKey',
'value' => 'testValue'
]
]
]
]
];

$this->setMockEntities($extendedDataObject);

$this->expectExceptionMessage("Parent Entity parent not defined for Entity extended.");
DataObjectHandler::getInstance()->getObject("extended");
}

public function testAlreadyExtendedParentData()
{
$extendedDataObjects = [
'entity' => [
'extended' => [
'type' => 'testType',
'extends' => "parent"
],
'parent' => [
'type' => 'type',
'extends' => "grandparent"
],
'grandparent' => [
'type' => 'grand'
]
]
];

$this->setMockEntities($extendedDataObjects);

$this->expectExceptionMessage(
"Cannot extend an entity that already extends another entity. Entity: parent." . PHP_EOL
);
DataObjectHandler::getInstance()->getObject("extended");
}

public function testExtendedVarGetter()
{
$extendedDataObjects = [
'entity' => [
'extended' => [
'type' => 'testType',
'extends' => "parent"
],
'parent' => [
'type' => 'type',
'var' => [
'someOtherEntity' => [
'entityType' => 'someOtherEntity',
'entityKey' => 'id',
'key' => 'someOtherEntity'
]
]
]
]
];

$this->setMockEntities($extendedDataObjects);
$resultextendedDataObject = DataObjectHandler::getInstance()->getObject("extended");
// Perform Asserts
$this->assertEquals("someOtherEntity->id", $resultextendedDataObject->getVarReference("someOtherEntity"));
}

public function testGetLinkedEntities()
{
$extendedDataObjects = [
'entity' => [
'extended' => [
'type' => 'testType',
'extends' => "parent"
],
'parent' => [
'type' => 'type',
'requiredEntity' => [
'linkedEntity1' => [
'type' => 'linkedEntityType',
'value' => 'linkedEntity1'
],
'linkedEntity2' => [
'type' => 'otherEntityType',
'value' => 'linkedEntity2'
],
]
]
]
];

$this->setMockEntities($extendedDataObjects);
// Perform Asserts
$resultextendedDataObject = DataObjectHandler::getInstance()->getObject("extended");
$this->assertEquals("linkedEntity1", $resultextendedDataObject->getLinkedEntitiesOfType("linkedEntityType")[0]);
$this->assertEquals("linkedEntity2", $resultextendedDataObject->getLinkedEntitiesOfType("otherEntityType")[0]);
}

private function setMockEntities($mockEntityData)
{
$property = new \ReflectionProperty(DataObjectHandler::class, 'INSTANCE');
$property->setAccessible(true);
$property->setValue(null);

$mockDataProfileSchemaParser = AspectMock::double(DataProfileSchemaParser::class, [
'readDataProfiles' => $mockEntityData
])->make();

$mockObjectManager = AspectMock::double(ObjectManager::class, [
'create' => $mockDataProfileSchemaParser
])->make();

AspectMock::double(ObjectManagerFactory::class, [
'getObjectManager' => $mockObjectManager
]);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
use Magento\FunctionalTestingFramework\ObjectManagerFactory;
use Magento\FunctionalTestingFramework\Page\Handlers\PageObjectHandler;
use Magento\FunctionalTestingFramework\XmlParser\PageParser;
use PHPUnit\Framework\TestCase;
use Magento\FunctionalTestingFramework\Util\MagentoTestCase;

class PageObjectHandlerTest extends TestCase
class PageObjectHandlerTest extends MagentoTestCase
{
public function testGetPageObject()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
use Magento\FunctionalTestingFramework\ObjectManagerFactory;
use Magento\FunctionalTestingFramework\Page\Handlers\SectionObjectHandler;
use Magento\FunctionalTestingFramework\XmlParser\SectionParser;
use PHPUnit\Framework\TestCase;
use Magento\FunctionalTestingFramework\Util\MagentoTestCase;

class SectionObjectHandlerTest extends TestCase
class SectionObjectHandlerTest extends MagentoTestCase
{
public function testGetSectionObject()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@

use Magento\FunctionalTestingFramework\Exceptions\XmlException;
use Magento\FunctionalTestingFramework\Page\Objects\ElementObject;
use PHPUnit\Framework\TestCase;
use Magento\FunctionalTestingFramework\Util\MagentoTestCase;

/**
* Class ElementObjectTest
*/
class ElementObjectTest extends TestCase
class ElementObjectTest extends MagentoTestCase
{
/**
* Timeout should be null when instantiated with '-'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@
namespace tests\unit\Magento\FunctionalTestFramework\Page\Objects;

use Magento\FunctionalTestingFramework\Page\Objects\PageObject;
use PHPUnit\Framework\TestCase;
use Magento\FunctionalTestingFramework\Util\MagentoTestCase;

/**
* Class PageObjectTest
*/
class PageObjectTest extends TestCase
class PageObjectTest extends MagentoTestCase
{
/**
* Assert that the page object has a section
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@

use Magento\FunctionalTestingFramework\Page\Objects\ElementObject;
use Magento\FunctionalTestingFramework\Page\Objects\SectionObject;
use PHPUnit\Framework\TestCase;
use Magento\FunctionalTestingFramework\Util\MagentoTestCase;

/**
* Class SectionObjectTest
*/
class SectionObjectTest extends TestCase
class SectionObjectTest extends MagentoTestCase
{
/**
* Assert that the section object has an element
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@
use Magento\FunctionalTestingFramework\Suite\Parsers\SuiteDataParser;
use Magento\FunctionalTestingFramework\Test\Handlers\TestObjectHandler;
use Magento\FunctionalTestingFramework\Test\Parsers\TestDataParser;
use PHPUnit\Framework\TestCase;
use Magento\FunctionalTestingFramework\Util\MagentoTestCase;
use tests\unit\Util\SuiteDataArrayBuilder;
use tests\unit\Util\TestDataArrayBuilder;

class SuiteObjectHandlerTest extends TestCase
class SuiteObjectHandlerTest extends MagentoTestCase
{
/**
* Tests basic parsing and accesors of suite object and suite object supporting classes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@
use Magento\FunctionalTestingFramework\Test\Util\TestObjectExtractor;
use Magento\FunctionalTestingFramework\Test\Parsers\TestDataParser;
use Magento\FunctionalTestingFramework\Util\Manifest\DefaultTestManifest;
use PHPUnit\Framework\TestCase;
use Magento\FunctionalTestingFramework\Util\MagentoTestCase;
use tests\unit\Util\SuiteDataArrayBuilder;
use tests\unit\Util\TestDataArrayBuilder;
use tests\unit\Util\TestLoggingUtil;

class SuiteGeneratorTest extends TestCase
class SuiteGeneratorTest extends MagentoTestCase
{

/**
Expand Down Expand Up @@ -76,7 +76,7 @@ public function testGenerateSuite()
TestLoggingUtil::getInstance()->validateMockLogStatement(
'info',
"suite generated",
['suite' => 'basicTestSuite', 'relative_path' => "_generated/basicTestSuite"]
['suite' => 'basicTestSuite', 'relative_path' => "_generated" . DIRECTORY_SEPARATOR . "basicTestSuite"]
);
}

Expand Down Expand Up @@ -105,15 +105,15 @@ public function testGenerateAllSuites()
$this->setMockTestAndSuiteParserOutput($mockTestData, $mockData);

// parse and retrieve suite object with mocked data
$exampleTestManifest = new DefaultTestManifest([], "sample/path");
$exampleTestManifest = new DefaultTestManifest([], "sample" . DIRECTORY_SEPARATOR . "path");
$mockSuiteGenerator = SuiteGenerator::getInstance();
$mockSuiteGenerator->generateAllSuites($exampleTestManifest);

// assert that expected suites are generated
TestLoggingUtil::getInstance()->validateMockLogStatement(
'info',
"suite generated",
['suite' => 'basicTestSuite', 'relative_path' => "_generated/basicTestSuite"]
['suite' => 'basicTestSuite', 'relative_path' => "_generated" . DIRECTORY_SEPARATOR . "basicTestSuite"]
);
}

Expand Down Expand Up @@ -206,5 +206,6 @@ private function setMockTestAndSuiteParserOutput($testData, $suiteData)
public static function tearDownAfterClass()
{
TestLoggingUtil::getInstance()->clearMockLoggingUtil();
parent::tearDownAfterClass();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@

use Magento\FunctionalTestingFramework\Exceptions\Collector\ExceptionCollector;
use Magento\FunctionalTestingFramework\Test\Config\ActionGroupDom;
use PHPUnit\Framework\TestCase;
use Magento\FunctionalTestingFramework\Util\MagentoTestCase;

class ActionGroupDomTest extends TestCase
class ActionGroupDomTest extends MagentoTestCase
{
/**
* Test Action Group duplicate step key validation
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
use Magento\FunctionalTestingFramework\Test\Parsers\TestDataParser;
use Magento\FunctionalTestingFramework\Test\Util\ActionObjectExtractor;
use Magento\FunctionalTestingFramework\Test\Util\TestObjectExtractor;
use PHPUnit\Framework\TestCase;
use Magento\FunctionalTestingFramework\Util\MagentoTestCase;
use tests\unit\Util\TestDataArrayBuilder;

class TestObjectHandlerTest extends TestCase
class TestObjectHandlerTest extends MagentoTestCase
{
/**
* Basic test to validate array => test object conversion.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@
use Magento\FunctionalTestingFramework\Test\Objects\ActionGroupObject;
use Magento\FunctionalTestingFramework\Test\Objects\ActionObject;
use Magento\FunctionalTestingFramework\Test\Objects\ArgumentObject;
use PHPUnit\Framework\TestCase;
use Magento\FunctionalTestingFramework\Util\MagentoTestCase;
use tests\unit\Util\ActionGroupObjectBuilder;
use tests\unit\Util\EntityDataObjectBuilder;
use tests\unit\Util\TestLoggingUtil;

class ActionGroupObjectTest extends TestCase
class ActionGroupObjectTest extends MagentoTestCase
{
const ACTION_GROUP_MERGE_KEY = 'TestKey';

Expand Down
Loading