Skip to content

MQE-812: Tests/Action Groups should infer order based on the top level argument #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 14, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Tests and ActionGroups now accept a new attribute insertBefore="" and insertAfter="". These cause all contents of the Test/ActionGroup to be inserted sequentially according to the stepKey provided in the attribue.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

…l argument

- Test/Dom.php now checks for a test to have a before/after attribute, if found it appends the before/after to all child actions for merging down the line.
…l argument

- updated ActionGroups to work with this
- need verification tests still
…l argument

- verification updates
- dom.php refactor and fixes.
…l argument

- Fix to old verification tests, found and fixed a bug with old merging.
- final test fixes.
@coveralls
Copy link

coveralls commented May 8, 2018

Coverage Status

Coverage increased (+0.4%) to 57.314% when pulling b28252d on MQE-812 into 48bbdb6 on develop.

imeron2433 and others added 2 commits May 9, 2018 19:02
…l argument

- Updated Verification Resources to reflect inclusion of Features annotation
@aljcalandra aljcalandra merged commit 15d7407 into develop May 14, 2018
@aljcalandra aljcalandra deleted the MQE-812 branch May 14, 2018 21:22
magento-devops-reposync-svc pushed a commit that referenced this pull request Nov 13, 2021
MQE-2677: Add filter for groups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants