Skip to content

MQE-978: Create Test Coverage Around SuiteGenerator Class #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2018

Conversation

aljcalandra
Copy link
Contributor

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-cicd2
Copy link

magento-cicd2 commented May 1, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ aljcalandra
❌ Alexander Calandra


Alexander Calandra seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 50.612% when pulling 0cbcfe1 on MQE-978 into 4e1affe on develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 50.612% when pulling 0cbcfe1 on MQE-978 into 4e1affe on develop.

@coveralls
Copy link

coveralls commented May 1, 2018

Coverage Status

Coverage increased (+0.3%) to 50.612% when pulling e2e1aae on MQE-978 into 4e1affe on develop.

- Adding unit tests for generateSuite and generateAllSuites
- Removed unused code from SuiteGenerator Class
- Removing CLEARED_MANIFESTS reference
- Adjusting comment text
@imeron2433 imeron2433 merged commit a955ad1 into develop May 1, 2018
@imeron2433 imeron2433 deleted the MQE-978 branch May 1, 2018 21:03
magento-devops-reposync-svc pushed a commit that referenced this pull request Sep 7, 2021
…o2-functional-testing-framework-870

[Imported] Removing the `csharpru/vault-php-guzzle6-transport` not needed dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants