Pangolins Sprint 12 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed resolveTestVariable to process each arg individually, as opposed to the whole string. - fixed quote breaking issue. - consolidated and refactored code around persisted data replacement.
…ing-framework into sprint-develop
- Adding the "comment" method to the MagentoWebDriver/Test Schema file. - Adding the "comment" method to the di.xml so it can appear multiple times in a single <test>.
- Adding the "clearField" method to the MagentoWebDriver file. - Adding the "clearField" method to the Test Schema. - Adding the "clearField" method to the di.xml so it can be listed multiple times in a test.
…onal-testing-framework into sprint-develop
- change output deletion behavior
- fix codesniffer method
- add new metadata generator util
- add new example input file
- change dir setup util to exposer public recursive delete
…ueness function correctly (#25) - ParameterArray now correctly replaces "{{data.key}}" uniqueness. - Verification test creation - add support for consistent array declaration - change functionality for pressKey - add exception for improperly formatted parameter array
- add support for unspecified data values in entities
…rged tests. - Changed setter of argData[argument] to not error on null arguments.
…ters - Use PHP_EOL instead of '\n'
- Changed Constant to variable. Constant is now merged actionObject Attributes.
…ized selector - Persisted Data fixes to Anthoula's patch. - Fixed quote logic, caught via verification tests.
…t doesn't exist - Throwing testReferenceException if actionGroup returned is null.
…ueness function correctly (#25) - ParameterArray now correctly replaces "{{data.key}}" uniqueness. - Verification test creation - add support for consistent array declaration - change functionality for pressKey - add exception for improperly formatted parameter array
…rged tests. - Changed setter of argData[argument] to not error on null arguments.
- add new verification tests around action-group - edit action group arg in unit test for failure - add verification tests around merge of xml
…bstr_count() when using php < 7.1.
okolesnyk
requested changes
Nov 7, 2017
| @@ -0,0 +1,36 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Test files must be named starting from Uppercase. MergeBaseFunctionalCest.xml
| <fillField mergeKey="fillField2" selector="{{SampleSection.newElement}}" userInput="{{defaultPerson.newField}}" /> | ||
| </test> | ||
| </cest> | ||
| </config> |
| @@ -0,0 +1,30 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Test files must be names starting from Uppercase. MergeInFunctionalCest.xml
| <actionGroup ref="functionalActionGroupWithData" mergeKey="step8Merge" after="step7Merge"/> | ||
| </test> | ||
| </cest> | ||
| </config> |
There was a problem hiding this comment.
New line missed at the end of file
| @@ -0,0 +1,41 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Action groups must be named starting from Uppercase. FunctionalActionGroup.xml
| /** | ||
| * Clear the given Text Field or Textarea | ||
| * | ||
| * @param string $selector |
| * | ||
| * @var Mustache_Engine | ||
| */ | ||
| private $mustache_engine; |
There was a problem hiding this comment.
Properties must be named using lowerCamelCase naming convention.
| * | ||
| * @return void | ||
| */ | ||
| private function initMustacheTemplates() |
There was a problem hiding this comment.
Init methods should be avoided to simplify extensibility of class.
| <operation name="{{operationName}}" dataType="{{operationDataType}}" type="create" auth="adminFormKey" url="{{operationUrl}}" method="POST"> | ||
| {{>object}} | ||
| </operation> | ||
| </config> |
There was a problem hiding this comment.
New line at the end of file missed
| {{> object}} | ||
| {{/hasChildObj}} | ||
| </object> | ||
| {{/objects}} |
There was a problem hiding this comment.
New line at the end of file missed
- Fix Alex's feedback
|
|
- Use git mv to force rename
okolesnyk
approved these changes
Nov 7, 2017
mmansoor-magento
pushed a commit
that referenced
this pull request
Nov 5, 2020
Master >> develop after 3.2.0 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Stories
Bugs
Related Pull Requests