Skip to content

Do not allow for $data.key$ replacement in selector parameters #107

Closed
@magterskine

Description

@magterskine

Given the following element and test action:

//In AdminLoginFormSection

<element name="paramelement" type="button" selector="{{var1}}" parameterized="true"/>
<click stepKey="1" selector="{{AdminLoginFormSection.paramelement('SomeString.$data.key$.after')}}"/>

The Generator actually outputs

$I->click("SomeString." . $data->getCreatedDataByName('key') . ".after");

We do not want to allow this kind of nested replacement, as this kind of replacement can't be replicated nested xml.data references (and is a door to recursive replacement we do not want to be open).

Expected result

ActionObject detects when a user is attempting to input $data.key$ references inside arguments for parameterized selectors/urls and throws a warning/dies.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions