Skip to content

[Problem] Namespace conflict with core rules  #45

Closed
@lenaorobei

Description

@lenaorobei

Problem overview

The future direction of magento/magento-coding-standard project is to deliver unified Coding Standard to the Magento core.
For backward compatibility dev/tests/static/framework/Magento/ruleset.xml should not be removed. In this case both coding standards will have name Magento and PHP CodeSniffer will be not able to process it.

Solution

Rename Magento magento/magento-coding-standard to MagentoCS. So dev/tests/static/framework/Magento/ruleset.xml will look like:

<ruleset name="Magento">
    <description>Custom Magento coding standard.</description>
    <rule ref="MagentoCS"/>
</ruleset>

Metadata

Metadata

Assignees

Labels

acceptedNew rule is acceptedproposalNew rule proposal

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions