Improve message for sniff for constants (rule 107)

[krisdante]

Description

#107 message says:

Constants must have short description if they add information beyond what the constant name supplies.

This is missleading message as this warning is shown for all the constants. Even obvious ones as NUMBER_PI=3.14.

Expected behavior

The message shall say:
Constants must have short description

Benefits

Less missleading

[lenaorobei]

Hi @krisdante. Could you please share the whole code snipped including PHP DocBlock?
Let me share the expected behavior of this rule.

Not OK (Description duplicates the name):

/**
 * Nesting separator.
 */
const NESTING_SEPARATOR = '->';

OK (no description):

const NESTING_SEPARATOR = '->';

OK (meaningful description):

/**
 * Some additional description beyond what the constant name supplies.
 */
const NESTING_SEPARATOR = '->';

[krisdante]

Yes, you are right. I got confused by the message.