This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Updated custom VCL documentation #6833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed topic title from "Secure access to the Magento Admin UI" to more generic "Create custom VCL for IP allowlist" - Clarified VCL snippet JSON example showing allowlist logic and the two options for adding from Magento Admin or using Fastly API - Renamed Custom VCL for blocking topic ==> Custom VCL for IP block list to match the topic title for allowlist - Updated topic titles in TOC - Updated all custom VCL example topics to have parallel structure and content - Removed escaping from VCL code examples -- escaping only needed if you submit snippet as JSON string -- and added note about when to escape special characters with link to Fastly VCL reference for examples.
meker12
added
the
Internal Dev
michaelcasey316
suggested changes
Mar 12, 2020
Co-Authored-By: Michael Casey <mcasey@magento.com>
Co-Authored-By: Michael Casey <mcasey@magento.com>
Co-Authored-By: Michael Casey <mcasey@magento.com>
Co-Authored-By: Michael Casey <mcasey@magento.com>
Co-Authored-By: Michael Casey <mcasey@magento.com>
Co-Authored-By: Michael Casey <mcasey@magento.com>
Co-Authored-By: Michael Casey <mcasey@magento.com>
Co-Authored-By: Michael Casey <mcasey@magento.com>
Co-Authored-By: Michael Casey <mcasey@magento.com>
meker12
commented
Mar 13, 2020
Co-Authored-By: Michael Casey <mcasey@magento.com>
meker12
commented
Mar 16, 2020
hguthrie
suggested changes
Mar 16, 2020
meker12
commented
Mar 17, 2020
meker12
commented
Mar 17, 2020
meker12
commented
Mar 17, 2020
Why do you not work locally? Seems to be extra work to do this in the GitHub interface for your own PR. |
meker12
commented
Mar 17, 2020
meker12
commented
Mar 17, 2020
meker12
commented
Mar 17, 2020
meker12
commented
Mar 17, 2020
…com:magento/devdocs into mae-magecloud-4821-fastly-allowlist-updates
michaelcasey316
approved these changes
Mar 18, 2020
hguthrie
reviewed
Mar 18, 2020
Co-Authored-By: hguthrie <hguthrie@users.noreply.github.com>
hguthrie
approved these changes
Mar 18, 2020
|
running tests |
|
Hi @meker12, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Per support feedback, updated Fastly custom VCL topics in the Cloud Guide to improve documentation for creating custom IP allowlists. (MAGECLOUD-4821)
Also, cleaned up all custom VCL topics:
To do
Affected DevDocs pages
https://devdocs.magento.com/cloud/cdn/cloud-vcl-custom-snippets.md
https://devdocs.magento.com/cloud/cdn//fastly-vcl-badreferer.md
https://devdocs.magento.com/cloud/cdn/fastly-vcl-blocking.md
https://devdocs.magento.com/cloud/cdn/fastly-vcl-whitelist.md
https://devdocs.magento.com/cloud/cdn/fastly-vcl-wordpress.md
https://devdocs.magento.com/cloud/trouble/robots-sitemap.md