This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Updating EntityUrl output object in urlResolvers query #6812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Ziffity
partners-contribution
|
An admin must run tests on this PR before it can be merged. |
rogyar
suggested changes
Mar 9, 2020
| @@ -63,7 +66,7 @@ Attribute | Data Type | Description | |||
| `id` | Int | The ID assigned to the object associated with the specified `url`. This could be a product ID, category ID, or page ID. | |||
| `relative_url` | String | The internal relative URL. If the specified `url` is a redirect, the query returns the redirected URL, not the original. | |||
| `type` | UrlRewriteEntityTypeEnum | The value of `UrlRewriteEntityTypeEnum` is one of PRODUCT, CATEGORY, or CMS_PAGE. | |||
| `url` | String | The URL to resolve. Magento stores product and category URLs with the `.html` extension. CMS URLs do not contain the extension. | |||
| `redirectCode` | Int | 301 or 302 HTTP code for url permanent or temporary redirect or 0 for the 200 no redirect. | |||
There was a problem hiding this comment.
Let's make this statement simpler.
Suggested change
| `redirectCode` | Int | 301 or 302 HTTP code for url permanent or temporary redirect or 0 for the 200 no redirect. | |
| `redirectCode` | Int | 301 or 302 HTTP status code for URL permanent or temporary redirect. Contains 0 when there's no redirect. |
keharper
reviewed
Mar 9, 2020
| type | ||
|
|
keharper
approved these changes
Mar 9, 2020
keharper
added
Technical
|
@rogyar I rewrote the description for |
rogyar
approved these changes
Mar 10, 2020
|
running tests |
|
Hi @VinothKumar361, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) updates the EntityUrl output object in urlResolvers query.As seen in this page (https://github.com/magento/magento2/blob/5f3b86ab4bd3e3b94e65429fed33f748d29c1bbe/app/code/Magento/UrlRewriteGraphQl/etc/schema.graphqls#L12) there is no url attribute in EntityUrl output object also the redirectCode attribute is missing in the docs.
Affected DevDocs pages
Links to Magento source code
https://github.com/magento/magento2/blob/5f3b86ab4bd3e3b94e65429fed33f748d29c1bbe/app/code/Magento/UrlRewriteGraphQl/Model/Resolver/EntityUrl.php#L115